Re: [PATCH] Enable Intel AGP on x86-64

[Dave Jones]

On Thu, Feb 19, 2004 at 02:11:49AM +0100, Andi Kleen wrote:

 > > Please don't do this. At least copy intel-agp.c to
 > > something new and throw out all the dozens of chipsets
 > > that will never appear on ia32e.
 > > 
 > > Splitting agpgart up to seperate drivers allowed us
 > > to stop adding cruft upon cruft with each generation
 > > of chipsets.  I don't want to have to spend half of
 > > 2.7 decrufting agpgart again.
 > 
 > Huh? Did you actually read the patch?

Yes, did you actually read my mail?

 > It doesn't change the AGP driver at all, just enables it in Kconfig because
 > Intel chipsets can be now used on the x86-64 kernel too.

You *really* think you're going to see a 440BX GART on ia32e ?
i810 ? i820 ? i830 ? etc. etc. I'd be *very* surprised if anything
but the current generation of ia32 chipsets gets used on ia32e.
It just doesn't make sense.

Without even looking at the code I'll bet you can shrink it
by at least 75%.

		Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/