Re: 2.6.4-mm2

[Andrew Morton]

Chris Mason <mason@xxxxxxxx> wrote:
>
> Looks good, but I'm still having problems convincing pagevec_lookup_tag
> to return anything other than 0 when called from
> wait_on_page_writeback_range (ext2, ext3, reiserfs).  Any ideas?

This might help.  I'm testing this path now, so there may be more changes..

--- 25/mm/page-writeback.c~x	2004-03-17 15:43:40.102282112 -0800
+++ 25-akpm/mm/page-writeback.c	2004-03-17 15:43:52.317425128 -0800
@@ -702,7 +702,7 @@ int test_set_page_writeback(struct page 
 
 		spin_lock_irqsave(&mapping->tree_lock, flags);
 		ret = TestSetPageWriteback(page);
-		if (ret)
+		if (!ret)
 			radix_tree_tag_set(&mapping->page_tree, page->index,
 						PAGECACHE_TAG_WRITEBACK);
 		if (!PageDirty(page))

_

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/