Re: Segmentation fault in i810_audio.c:__i810_update_lvi

[Andrew Morton]

Gary Wong <gtw@xxxxxxxxx> wrote:
>
> I believe that one of two fixes should be applied: either the
>  SNDCTL_DSP_SETTRIGGER ioctl handling should not enable the
>  PCM_ENABLE_{IN,OUT}PUT bits unless file->f_mode is compatible,
>  or i810_release() should ignore the PCM_ENABLE_* bits without
>  the corresponding FMODE_*.

The first option sounds more appropriate but I wonder if it could break
existing applications?  Probably not, if it oopses.

Let's try option #1, please.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/