Re: [PATCH] efivars: check enabled {2.6.6 doesn't boot with 4k stacks}

[Matt Domsch]

On Mon, May 10, 2004 at 09:02:43PM -0700, Randy.Dunlap wrote:
> // linux-266
> // efivars_init and efivars_exit need to check efi_enabled
> // instead of assuming that the system is using EFI;

Good catch.  I missed the creation of that in the x86 EFI merge.

> +++ ./drivers/firmware/efivars.c	2004-05-10 20:45:55.000000000 -0700
> @@ -664,6 +664,9 @@ efivars_init(void)
>  	unsigned long variable_name_size = 1024;
>  	int i, rc = 0, error = 0;
>  
> +	if (!efi_enabled)
> +		return 0;

I would think this would be return -ENODEV; instead, yes?

Thanks,
Matt

-- 
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/