Re: [PATCH 2.6] Watchdog timer for Intel IXP4xx CPUs

[Andrew Morton]

Deepak Saxena <dsaxena@xxxxxxxxxxx> wrote:
>
> 
> Following patch against 2.6.6 adds a driver for the watchdogs on the
> Intel IXP4xx family of network processors (ARM). Please apply.
> 
> ...
> +
> +	clear_bit(1, &wdt_status);

It'd be nice to enumerate the bits in wdt_status.

> +
> +	case WDIOC_SETTIMEOUT:
> +		ret = get_user(time, (int *)arg);
> +		if (ret)
> +			break;
> +
> +		if (time <= 0 || time > 60) {
> +			ret = -EINVAL;
> +			break;
> +		}
> +
> +		heartbeat = time;
> +		wdt_enable();

Missing a break here?

> +	case WDIOC_GETTIMEOUT:
> +		ret = put_user(heartbeat, (int *)arg);
> +		break;
> +
> +	case WDIOC_KEEPALIVE:
> +		wdt_enable();
> +		ret = 0;
> +		break;
> +	}
> +	return ret;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/