Re: problem with sis900 driver 2.6.5 +

[Daniele Venzano]

On Tue, May 11, 2004 at 03:41:42PM -0300, Luiz Fernando N. Capitulino wrote:
> Em Tue, May 11, 2004 at 07:28:24PM +0100, mike escreveu:
> 
> | In kernels 2.6.5 and above (may affect 2.6.4 as well) there seems to be
> | a problem with the sis900 eth driver
> | 
> | I have a sis chipset with integrated ethernet sis900 driver which has
> | always worked perfectly up to and including 2.6.3 (fedora)
In that time frame (2.6.3->2.6.4) there has been only this change in the driver itself, 
could you try to revert it and see if the problem disappears ?

diff -Nru a/drivers/net/sis900.c b/drivers/net/sis900.c
--- a/drivers/net/sis900.c      Wed Mar 10 18:56:09 2004
+++ b/drivers/net/sis900.c      Wed Mar 10 18:56:09 2004
@@ -2093,7 +2093,7 @@
                     i++, mclist = mclist->next) {
                        unsigned int bit_nr =
                                sis900_mcast_bitnr(mclist->dmi_addr, revision);
-                       mc_filter[bit_nr >> 4] |= (1 << bit_nr);
+                       mc_filter[bit_nr >> 4] |= (1 << (bit_nr & 0xf));
                }
        }
 

Also, could you send full dmesg in working/not working case ?

Thanks.

-- 
-----------------------------
Daniele Venzano
Web: http://teg.homeunix.org

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/