Re: From Eric Anholt:

[Greg KH]

On Sat, Apr 10, 2004 at 04:32:02AM +0000, Linux Kernel Mailing List wrote:
> diff -Nru a/drivers/char/drm/drm.h b/drivers/char/drm/drm.h
> --- a/drivers/char/drm/drm.h	Tue May 11 15:11:32 2004
> +++ b/drivers/char/drm/drm.h	Tue May 11 15:11:32 2004
> @@ -580,6 +580,16 @@
>  	unsigned long handle;	/**< Used for mapping / unmapping */
>  } drm_scatter_gather_t;
>  
> +/**
> + * DRM_IOCTL_SET_VERSION ioctl argument type.
> + */
> +typedef struct drm_set_version {
> +	int drm_di_major;
> +	int drm_di_minor;
> +	int drm_dd_major;
> +	int drm_dd_minor;
> +} drm_set_version_t;
> +

Ick, you can't use "int" as an ioctl structure member, sorry.  Please
use the proper "__u16" or "__u32" value instead.

And what about kernels running in 64bit mode with 32bit userspace?  Care
to provide the proper thunking layer for them too?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/