Re: From Eric Anholt:

[Dave Airlie]

> >
> > +/**
> > + * DRM_IOCTL_SET_VERSION ioctl argument type.
> > + */
> > +typedef struct drm_set_version {
> > +	int drm_di_major;
> > +	int drm_di_minor;
> > +	int drm_dd_major;
> > +	int drm_dd_minor;
> > +} drm_set_version_t;
> > +
>
> Ick, you can't use "int" as an ioctl structure member, sorry.  Please
> use the proper "__u16" or "__u32" value instead.

okay I'll submit a fix to Linus rsn ...
>
> And what about kernels running in 64bit mode with 32bit userspace?  Care
> to provide the proper thunking layer for them too?

would love to don't have anyone on team that does 64-bit at the moment or
even has access to 64-bit hardware .. f someone provides the code I'll accept
it, anyway the DRM isn't completely 64-bit safe AFAIK, it has other
"issues",

Thanks,
Dave.

-- 
David Airlie, Software Engineer
http://www.skynet.ie/~airlied / airlied at skynet.ie
pam_smb / Linux DECstation / Linux VAX / ILUG person

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/