Re: [PATCH 2/2] Support for VIA PadLock crypto engine

[Michal Ludvig]

On Wed, 12 May 2004, James Morris wrote:

> On Tue, 11 May 2004, Michal Ludvig wrote:
>
> > Second patch - now the PadLock-specific part.
>
> Can you please just follow the model of arch/s390/crypto/ ?
>
> This is arch-specific hardware, and should not need any changes to the
> existing crypto API at this stage.

I only briefly looked at the s390 crypto driver and it looks like it uses
a special /dev node along with some read/write/ioctl calls to do the
encryption. I.e. it doesn't seem to integrate with the CryptoAPI at all.
How could that be used for e.g. IPsec, cryptoloop, etc?

My padlock driver can be used for anything that uses CryptoAPI and in fact
it speeds things a lot (see a simple disk-based benchmark at
http://www.logix.cz/michal/dl/padlock.xp).

In fact I believe that the hardware-specific drivers (e.g. the S/390 one)
should be used in the cryptoapi as well and then the kernel should provide
a single, universal device with read/write/ioctl calls for all of them.
Not making a separete device for every piece of hardware on the market.
Am I wrong?

Michal Ludvig
-- 
* A mouse is a device used to point at the xterm you want to type in.
* Personal homepage - http://www.logix.cz/michal
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/