Re: [tony@atomide.com: [PATCH] Powernow-k8 buggy BIOS override for 2.6.6]

[Tony Lindgren]

* Dave Jones <davej@xxxxxxxxxx> [040513 07:06]:
> On Wed, May 12, 2004 at 05:16:28PM -0700, Tony Lindgren wrote:
> 
>  > Following is the updated patch to make the powernow-k8 driver work on 
>  > machines with buggy BIOS, such as emachines m6805.
>  > 
>  > The patch overrides the PST table only if check_pst_table() fails.
>  > 
>  > The minimum value for the override is 800MHz, which is the lowest value 
>  > on all x86_64 systems AFAIK. The max value is the current running value.
>  > 
>  > This patch should be safe to apply, even if Pavel's ACPI table check is
>  > added to the driver. Or does anybody see a problem with it?
> 
> Does the ACPI fallback not do the right thing ?

Does not work for me. But looks like that's because I had to turn off 
ACPI processor module since 2.6.6 since it would hang my system. It could 
also be that the hang is caused by the powernow-k8. I will check that.

> I don't really see the point of limping along with a 2-state PST
> if we can derive the proper info from the ACPI table.

Sure if the ACPI table check works properly. But even with 2-state PST,
being able to change from 1800MHz to 800MHz on battery increases the 
battery life quite a bit. And it does not necessarily require ACPI :)

Regards,

Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/