Re: 2.6.7-rc1 breaks forcedeth

[Linus Torvalds]

On Sun, 6 Jun 2004, Jeff Garzik wrote:
> 
> So by definition it is a driver bug if the hardware is sending irqs 
> outside of when the driver indicates interest in the irq via 
> request_irq...free_irq.

Fair enough. It's sometimes easier to just register the driver irq early, 
though, to take care of all the cases that can happen. In particular, if 
you know you may have pending interrupts, and your irq handler is good at 
clearing them (it had better be), the easiest solution may well be to just 
register early.

> Also, PCI 2.3 devices have an "interrupt disable" bit in PCI_COMMAND 
> they can use, iff (a) it's implemented and (b) the driver isn't using MSI.

Now _this_ will help. However, I suspect it will help three years down the
line, not now. It should have been there originally, it would have solved 
a lot of problems.

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/