Re: [RFC] Host Virtual Serial Interface driver

[Hollis Blanchard]

On Monday 09 August 2004 13:48, Sam Ravnborg wrote:
> > #warning here
>
> This "#warning" should be deleted..

Right, sorry. A bookmark... :)

> > #ifdef DEBUG
> > 	pr_debug("%s: sending %i bytes\n", __FUNCTION__, packet.len);
> > 	dump_hex((uint8_t*)&packet, packet.len);
> > #endif
>
> pr_debug is a noop if DEBUG is not defined. Make dump_hex, dump_packet
> be a noop also and you get rid of several #ifdef in the code.

I'd like to do that, but notice that dump_hex() is called from dump_packet() 
from hvsi_recv_response() (and I've just made hvsi_recv_control() the same). 
Even with debug disabled, I'd like to be able to dump a whole packet if I get 
confused...

-- 
Hollis Blanchard
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/