Re: [RFC] Host Virtual Serial Interface driver

From: Michael Buesch
Date: Mon Aug 09 2004 - 14:27:10 EST


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoting Hollis Blanchard <hollisb@xxxxxxxxxx>:
> > pr_debug is a noop if DEBUG is not defined. Make dump_hex, dump_packet
> > be a noop also and you get rid of several #ifdef in the code.
>
> I'd like to do that, but notice that dump_hex() is called from dump_packet()
> from hvsi_recv_response() (and I've just made hvsi_recv_control() the same).
> Even with debug disabled, I'd like to be able to dump a whole packet if I get
> confused...

#ifdef DEBUG
# define dump_hex_dbg(a, b) dump_hex(a, b)
#else
# define dump_hex_dbg(a, b) do { } while (0)
#endif /* DEBUG */

- --
Regards Michael Buesch [ http://www.tuxsoft.de.vu ]


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBF8yWFGK1OIvVOP4RAv3xAJ91heLG1BQzB+rLkA7w3D+3RhRdYgCg4pMI
uTJPQXzVvJppF14S71neVnI=
=zDzy
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/