Re: [PATCH] 2.6.8 synclink_cs.c replace syncppp with genhdlc

[Paul Fulghum]

On Mon, 2004-08-16 at 10:21, Christoph Hellwig wrote:
> > +#ifdef CONFIG_HDLC_MODULE
> > +#define CONFIG_HDLC 1
> >  #endif
> 
> shouldn't the drivers depend on hdlc instead?

They do.

When hdlc is enabled as a module:
CONFIG_HDLC_MODULE is defined
CONFIG_HDLC is not defined

When hdlc is enabled in kernel:
CONFIG_HDLC_MODULE is not defined
CONFIG_HDLC is defined

The HDLC interface in the synclink modules need
to be enabled for either case.
All the conditional compilation is done
on CONFIG_HDLC, and the above fragment
defines CONFIG_HDLC when HDLC is built as a
module.

Is there a better way of handling this?
 
--
Paul Fulghum
paulkf@xxxxxxxxxxxxx


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/