Re: 2.6.11-mm1 (x86-abstract-discontigmem-setup.patch)

[Alexey Dobriyan]

> --- 25/arch/i386/mm/discontig.c~x86-abstract-discontigmem-setup
> +++ 25-akpm/arch/i386/mm/discontig.c

> +void memory_present(int nid, unsigned long start, unsigned long end)
> +{
> +	unsigned long pfn;
> +
> +	printk(KERN_INFO "Node: %d, start_pfn: %ld, end_pfn: %ld\n",
> +			nid, start, end);
> +	printk(KERN_DEBUG "  Setting physnode_map array to node %d for pfns:\n", nid);
> +	printk(KERN_DEBUG "  ");
> +	for (pfn = start; pfn < end; pfn += PAGES_PER_ELEMENT) {
> +		physnode_map[pfn / PAGES_PER_ELEMENT] = nid;
> +		printk(KERN_DEBUG "%ld ", pfn);
		       ^^^^^^^^^^

> +	}
> +	printk(KERN_DEBUG "\n");
	       ^^^^^^^^^^
> +}

Too much KERN_DEBUG.

> --- 25/include/linux/mmzone.h~x86-abstract-discontigmem-setup
> +++ 25-akpm/include/linux/mmzone.h

> +#ifdef CONFIG_HAVE_MEMORY_PRESENT
> +void memory_present(int nid, unsigned long start, unsigned long end);
> +#else
> +static inline void memory_present(int nid, unsigned long start, unsigned long end) {}
> +#endif

> +#ifdef CONFIG_NEED_NODE_MEMMAP_SIZE
> +unsigned long __init node_memmap_size_bytes(int, unsigned long, unsigned long);
> +#endif

	#else
	static inline unsigned long node_memmap_size_bytes(...);
	#endif

Is this needed?

	Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/