Re: [patch] fix NULL pointer deference in ALPS

[Benoit Boissinot]

On Mon, Mar 07, 2005 at 04:06:33PM +0200, Alexey Dobriyan wrote:
> On Monday 07 March 2005 14:24, Benoit Boissinot wrote:
> 
> > alps_get_model returns a pointer or NULL in case of errors, so we need to
> > check for the results being NULL, not negative.
> 
> 2.6.11-bk2:	int alps_get_model(struct psmouse *psmouse)
> 	takes 1 argument, returns -1 on error
> 
> 2.6.11-mm1:	static struct alps_model_info *alps_get_model(struct psmouse *psmouse, int *version)
> 	takes 2 arguments, returns NULL on error
>

Sorry, i misreaded the vanilla code, it only applies to -mm.

Since it seems to be fixed in bk-input, please forget the patch.

Sorry.

Benoit
-- 
powered by bash/screen/(urxvt/fvwm|linux-console)/gentoo/gnu/linux OS
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/