Re: [PATCH] NMI/CMOS RTC race fix for x86-64

[Andi Kleen]

> >But in this case it isnt. Instead of all this complexity 
> >just remove the NMI reassert code from the NMI handler.
> >It is oudated and mostly useless on modern systems anyways.
> > 
> >
> "mostly useless" and "completely useless" are two different things.

It's completely useless (double checked the AMD8111 and ICH5 data sheets)

There is nothing that should ever clear the NMI bit in this register.
In fact the ICH5 datasheet even explicitely says software should
never touch this bit. 

It may have some meaning in ancient ISA chipsets, but that is 
of no concern on x86-64.

> Do you want me to submit a patch that simply removes this?

Yes, please.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/