Re: [PATCH] kill old EH constants

[Sam Creasey]

On Thu, 21 Apr 2005, Christoph Hellwig wrote:

> On Thu, Apr 21, 2005 at 11:58:12AM +0200, Geert Uytterhoeven wrote:
> > sun3_NCR5380.c still uses the following:
> >
> >   - SCSI_ABORT_SUCCESS
> >   - SCSI_ABORT_ERROR
> >   - SCSI_ABORT_SNOOZE
> >   - SCSI_ABORT_BUSY
> >   - SCSI_ABORT_NOT_RUNNING
> >   - SCSI_RESET_SUCCESS
> >   - SCSI_RESET_BUS_RESET
> >
> > causing the driver to fail to build in 2.6.12-rc3. What should I replace them
> > by?
>
> You must replace NCR5380_abort and NCR5380_bus_reset with real new-style
> EH routines.  I'd suggest copying them from NCR5380.c or even better
> scrapping sun3_NCR5380.c in favour of that one completely.

Trust me, there's reasons we don't use NCR5380.c.... (primarily, this has
to due with the order of operations necessary to keep the DMA controller
happpy, which required changing the flow of several functions
(admittedly, I haven't looked into this again since the "new-style"
driver change)).

That being said, it seems the first option needs done.  I suppose I'll
add fixing those two routines to my long list of backlogged sun3 stuff
which needs doing.

-- Sam


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/