Re: [2.6 patch] unexport is_console_locked

[Andrew Morton]

Adrian Bunk <bunk@xxxxxxxxx> wrote:
>
> I didn't find any possible modular usage in the kernel.
> 

Is needed for WARN_CONSOLE_UNLOCKED().

It just happens that WARN_CONSOLE_UNLOCKED() is currently only using in
vt.c, which just happens to not support modular usage.

But disabling this export would make WARN_CONSOLE_UNLOCKED() pretty useless
for driver development.

So I'd suggest that we either leave this symbol exported for driver
developers or we nuke WARN_CONSOLE_UNLOCKED() altogether.

Ben, do you still want it?


> --- linux-2.6.11-rc5-mm1-full/kernel/printk.c.old	2005-03-04 00:58:16.000000000 +0100
> +++ linux-2.6.11-rc5-mm1-full/kernel/printk.c	2005-03-04 00:58:22.000000000 +0100
> @@ -675,7 +675,6 @@
>  {
>  	return console_locked;
>  }
> -EXPORT_SYMBOL(is_console_locked);
>  
>  /**
>   * release_console_sem - unlock the console system
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/