Re: [2.6 patch] unexport is_console_locked

[Benjamin Herrenschmidt]

On Sat, 2005-04-23 at 16:49 -0700, Andrew Morton wrote:
> Adrian Bunk <bunk@xxxxxxxxx> wrote:
> >
> > I didn't find any possible modular usage in the kernel.
> > 
> 
> Is needed for WARN_CONSOLE_UNLOCKED().
> 
> It just happens that WARN_CONSOLE_UNLOCKED() is currently only using in
> vt.c, which just happens to not support modular usage.
> 
> But disabling this export would make WARN_CONSOLE_UNLOCKED() pretty useless
> for driver development.
> 
> So I'd suggest that we either leave this symbol exported for driver
> developers or we nuke WARN_CONSOLE_UNLOCKED() altogether.
> 
> Ben, do you still want it?

Yes, I do. Please, keep it exported. On that note, I don't understand
that frenzy of unexporting everything you can, I find this useless
burden in general.

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/