Re: [PATCH 1/6] new timeofday core subsystem for -mm (v.B3)

[Roman Zippel]

Hi,

On Mon, 20 Jun 2005, Ulrich Windl wrote:

> it seems you don't like the patch for some personal reasons, and now your are 
> trying to find arguments against it.

Please stop trying such mind reading tricks.

> > fix it first, if the current system is a mess clean it up first, but 
> > don't mix these two steps, unless you want to introduce more broken mess.
> 
> If you introduce something new (higher resolution clock), you should start with 
> something clean. Just hacking it in the first attempt, anf then making it 
> beautiful in a second attempt is a waste of time IMHO.

Well, I'm not really convinced of the quality of the patch, if nobody can 
explain it to me and I don't think my questions were that unreasonable.
We are talking about a core subsystem here, which IMO justifies a little 
more care. Maybe you should follow the fs development a bit for an example 
how to do even large changes in relatively simple steps.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/