Re: [PATCH] Add removal schedule of register_serial/unregister_serial to appropriate file

[David McCullough]

Jivin Russell King lays it down ...
> On Thu, Jun 23, 2005 at 02:23:35PM +0100, Russell King wrote:
> > +What:	register_serial/unregister_serial
> > +When:	December 2005
> > +Why:	This interface does not allow serial ports to be registered against
> > +	a struct device, and as such does not allow correct power management
> > +	of such ports.  8250-based ports should use serial8250_register_port
> > +	and serial8250_unregister_port instead.
> > +Who:	Russell King <rmk@xxxxxxxxxxxxxxxx>
> 
> Ok, now that this is in, I guess I should arrange for register_serial &
> co to throw a compiler warning.  However, this is non-trivial because
> several other drivers declare this function:

...

> drivers/serial/68328serial.c:int register_serial(struct serial_struct *req)
> drivers/serial/68328serial.c:void unregister_serial(int line)

These can go.  AFAICT they were never used and I have no idea why they
are there.

Cheers,
Davidm

-- 
David McCullough, davidm@xxxxxxxxxxxx  Ph:+61 7 34352815 http://www.SnapGear.com
Custom Embedded Solutions + Security   Fx:+61 7 38913630 http://www.uCdot.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/