Re: [RFC] SPI core -- revisited

From: Greg KH
Date: Tue Jun 28 2005 - 11:53:09 EST


On Mon, Jun 27, 2005 at 02:20:26PM +0400, Vitaly Wool wrote:
> But -- does the interfaces review imply checking wthether the figure
> brackets are complying to K&R? ;)

Yes. If you get the coding style wrong, it's harder for all of us to
review the code. See my old OLS paper about coding style for the
research that backs this up.

Basically, if the format is wrong, your brain has a much harder time to
see the actual logic of your code. And you want us to review the logic
:)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/