Re: [PATCH] net: add driver for the NIC on Cell Blades

[Arnd Bergmann]

On Dinsdag 28 Juni 2005 15:53, Arjan van de Ven wrote:
> 
> > +static void
> > +spider_net_rx_irq_off(struct spider_net_card *card)
> > +{
> > +       u32 regvalue;
> > +       unsigned long flags;
> > +
> > +       spin_lock_irqsave(&card->intmask_lock, flags);
> > +       regvalue = spider_net_read_reg(card, SPIDER_NET_GHIINT0MSK);
> > +       regvalue &= ~SPIDER_NET_RXINT;
> > +       spider_net_write_reg(card, SPIDER_NET_GHIINT0MSK, regvalue);
> > +       spin_unlock_irqrestore(&card->intmask_lock, flags);
> > +}
> 
> I think you have a PCI posting bug here....

Could you be more specific? My guess would be that the 'sync' in writel
takes care of this. Should there be an extra mmiowb() in here or are
you referring to some other problem?

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/