Re: recent kprobe work

From: Andrew Morton
Date: Tue Jun 28 2005 - 20:05:26 EST


Rusty Lynch <rusty@xxxxxxxxxxxxxxx> wrote:
>
> On Tue, Jun 28, 2005 at 02:01:36PM -0700, David S. Miller wrote:
> >
> > Can the folks submitting all of the kprobe stuff at least consult me
> > when they can't figure out how to implement the sparc64 kprobe variant
> > for new features?
> >
> > Currently, the sparc64 build is broken by recent kprobe
> > changes:
> >
> > kernel/built-in.o: In function `init_kprobes':
> > : undefined reference to `arch_init'
> >
> > Also, can we use a more namespace friendly name for this kprobe layer
> > specific function other than "arch_init()"?
> >
> > Thanks.
>
> Sorry, just an oversight. We have several arch_* functions, maybe we should
> start using kprobes_arch_* instead.
>

Absolutely - please send a patch once Dave's fix is merged up.

Dave: sorry, I would have caught the missing reference except I'm totally
averse to `make allfooconfig' on non-x86[_64] architectures because so much
stuff simply doesn't work.

But lo. It does work on sparc64.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/