A couple of OOM killer races

From: Richard Hayden
Date: Thu Sep 01 2005 - 15:46:28 EST


Hi all,

It appears there is no protection in badness() (called by out_of_memory() for each process) when it reads p->mm->total_vm. Another processor (or a kernel preemption) could presumably run do_exit and then exit_mm, freeing the process in question's reference to its mm just after the (!p->mm) check but before it reads p->mm->total_vm, making the latter reference a null pointer reference.

Also there appears to be no protection when we set p->time_slice in __oom_kill_task(). Am I right in thinking that this field should be protected by the appropriate runqueue lock, at least this is what scheduler_tick() seems to use?

Have I missed anything?

Best regards,

Richard Hayden.


___________________________________________________________ How much free photo storage do you get? Store your holiday snaps for FREE with Yahoo! Photos http://uk.photos.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/