Re: Serial driver (serial_core.c) status messages should be set toKERN_INFO

From: Jiri Slaby
Date: Thu Sep 01 2005 - 15:43:07 EST


Alon Bar-Lev napsal(a):

Hello,


When upgrading to 2.6.13 I've noticed that serial driver reports it status with unknown severity, causing the boot-splash to be overridden.


Please consider this modification.


Best Regards,

Alon Bar-Lev.


At drivers/serial/serial_core.c


static inline void

uart_report_port(struct uart_driver *drv, struct uart_port *port)
{
- printk("%s%d", drv->dev_name, port->line);
+ printk(KERN_INFO + "%s%d", drv->dev_name, port->line);

plus sign between that?


printk(" at ");

why the fellows didn't put this to the line above?

switch (port->iotype) {
case UPIO_PORT:
printk("I/O 0x%x", port->iobase);

And what about these?

break;
case UPIO_HUB6:
printk("I/O 0x%x offset 0x%x", port->iobase, port->hub6);
break;
case UPIO_MEM:
case UPIO_MEM32:
printk("MMIO 0x%lx", port->mapbase);
break;
}
printk(" (irq = %d) is a %s\n", port->irq, uart_type(port));
}

regards,

--
Jiri Slaby www.fi.muni.cz/~xslaby
~\-/~ jirislaby@xxxxxxxxx ~\-/~
241B347EC88228DE51EE A49C4A73A25004CB2A10

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/