Re: Linux v2.6.14-rc4

From: David S. Miller
Date: Mon Oct 10 2005 - 22:59:36 EST


From: Al Viro <viro@xxxxxxxxxxxxxxxx>
Date: Tue, 11 Oct 2005 04:41:27 +0100

> On Mon, Oct 10, 2005 at 06:31:12PM -0700, Linus Torvalds wrote:
> > Tom 'spot' Callaway:
> > [SPARC32]: Enable generic IOMAP.
>
> ... breaks non-PCI builds (aka the absolute majority of sparc32 boxen).
> On sparc32 insl() et.al. are defined only if CONFIG_PCI is set.
>
> Moreover, I really doubt that generic_iomap is the right thing to do
> there - all these guys end up as memory dereferences anyway, so ioread...()
> et.al. have no reason to care about the origin of iomem pointer they get.

Also, Tom never answered my query about the driver he stated
this was needed for (sym53c8xx) which appears on no sparc32
PCI box in the world :-)

I'll revert this for now, push that to Linus, and we can hash it out
better in 2.6.15
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/