Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime))

[OGAWA Hirofumi]

Andrew Morton <akpm@xxxxxxxx> writes:

> However there's not much point in writing a brand-new function when
> write_inode_now() almost does the right thing.  We can share the
> implementation within fs-writeback.c.

Indeed. We use the generic_osync_inode() for it?

> Isn't write_inode_now() buggy?  If !mapping_cap_writeback_dirty() we
> should still write the inode itself?

Indeed. It seems we should write the dirty inode to backing device's buffers.
sync_sb_inodes() too?  If so, really buggy.. I'll check it.
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/