Re: [PATCH 1/2] miss-sync changes on attributes (Re: [PATCH 2/2][FAT] miss-sync issues on sync mount (miss-sync on utime))

[OGAWA Hirofumi]

OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> writes:

>> Isn't write_inode_now() buggy?  If !mapping_cap_writeback_dirty() we
>> should still write the inode itself?
>
> Indeed. It seems we should write the dirty inode to backing device's buffers.
> sync_sb_inodes() too?  If so, really buggy.. I'll check it.

write_inode_now() seems ok.

If !mapping_cap_writeback_dirty(), the inode is bdev_inode itself or
ram-based fs's inode, so ->write_inode() is not needed.  And if
backing_dev is ramdisk, mapping->backing_dev_info was setted the
following special bdi.

static struct backing_dev_info rd_file_backing_dev_info = {
	.ra_pages	= 0,			/* No readahead */
	.capabilities	= BDI_CAP_MAP_COPY,	/* Does contribute to dirty memory */
	.unplug_io_fn	= default_unplug_io_fn,
};
-- 
OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/