Re: [PATCH 18/39] NLKD/x86-64 - INT1/INT3 handling changes

[Andi Kleen]

On Thursday 10 November 2005 15:07, Jan Beulich wrote:
> >>> Andi Kleen <ak@xxxxxxx> 10.11.05 14:21:48 >>>
> >
> >On Wednesday 09 November 2005 15:13, Jan Beulich wrote:
> >> This
> >> - switches the INT3 handler to run on an IST stack (to cope with
> >>   breakpoints set by a kernel debugger on places where the kernel's
> >>   %gs base hasn't been set up, yet); the IST stack used is shared with
> >>   the INT1 handler's
> >> - allows nesting of INT1/INT3 handlers so that one can, with a kernel
> >>   debugger, debug (at least) the user-mode portions of the INT1/INT3
> >>   handling; the nesting isn't actively enabled here since a kernel-
> >>   debugger-free kernel doesn't need it
> >
> >Looks reasonable except for the CONFIG_NLKD hunk, which doesn't
> >seem to be related. I think I'll apply it without that.
>
> As the comment in that hunk says - this is not the correct test, but the
> correct test cannot be used. Omitting the hunk altogether will leave orphan
> references to the pda field (even though these won't cause build problems)
> in setup64.c and traps.c.

!NLKD code relying on CONFIG_NLKD code? That sounds wrong. I won't apply
it then. Please clean up first.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/