Re: [PATCH 18/39] NLKD/x86-64 - INT1/INT3 handling changes

[Jan Beulich]

>> >Looks reasonable except for the CONFIG_NLKD hunk, which doesn't
>> >seem to be related. I think I'll apply it without that.
>>
>> As the comment in that hunk says - this is not the correct test, but
the
>> correct test cannot be used. Omitting the hunk altogether will leave
orphan
>> references to the pda field (even though these won't cause build
problems)
>> in setup64.c and traps.c.
>
>!NLKD code relying on CONFIG_NLKD code? That sounds wrong. I won't
apply
>it then. Please clean up first.

Since the exception stack size doesn't get set to other than 4k, this
isn't by itself wrong (the NLKD patch later conditionally sets this to
more than 4k). The problem, as said in the patch, is that pda.h cannot
include processor.h, and I see no solution for that (other than breaking
up processor.h).

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/