Re: [PATCH 4/5] slab: extract slab order calculation to separatefunction

From: Manfred Spraul
Date: Sat Nov 19 2005 - 07:25:15 EST

Pekka Enberg wrote:

This patch moves the ugly loop that determines the 'optimal' size (page
order) of cache slabs from kmem_cache_create() to a separate function
and cleans it up a bit.

Thanks to Matthew Wilcox for the help with this patch.

Signed-off-by: Matthew Dobson <colpatch@xxxxxxxxxx>
Signed-off-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>

Looks good, just two minor points:

+static inline size_t calculate_slab_order(kmem_cache_t *cachep, size_t size,
+ size_t align, gfp_t flags)

Unnecessary inline, see my previous mail for the explanation.

+ } else
+ left_over = calculate_slab_order(cachep, size, align, flags);

I usually add braces in this case: If braces are necessary for either the if or the else-clause, then I add braces to both parts.

Could be applied as is, or I could write a patch with both changes.
Andrew - what do you prefer?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at