Re: [Lhms-devel] Re: [PATCH 1/5] Light Fragmentation Avoidance V20:001_antidefrag_flags

From: Paul Jackson
Date: Sun Nov 20 2005 - 09:45:39 EST


Mel wrote:
> +#define __GFP_EASYRCLM ((__force gfp_t)0x80000u)
>
> Comment to right removed because the comment above the declaration covers
> everything.

(repeating myself)
> How about fitting the style (casts, just one line) of the other flags,
> so that these added six lines become instead just the one line:

There is a consistent layout, one-per-line, to the other __GFP_*
flags. The information content of the extra five lines you use for
the __GFP_EASYRCLM flag does not warrant upsetting that layout, in
my view.

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@xxxxxxx> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/