Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference

[Jody McIntyre]

On Mon, Nov 21, 2005 at 10:56:09AM -0800, Ben Collins wrote:
> > 
> > This looks OK to me. But there seems to be another bug. I think the line
> > 
> > 	kfree(cache);
> > 
> > after the if and else blocks has to be replaced by
> > 
> > 	CSR1212_FREE(cache);
> 
> Yes, please. We are trying to keep the csr1212.[ch] files compatible for
> use in userspace and kernel.

raw1394.c does not have to be kept compatible.  Stefan's suggestion
doesn't hurt though.  Anyone have a patch?

Cheers,
Jody


> 
> -- 
> Ubuntu     - http://www.ubuntu.com/
> Debian     - http://www.debian.org/
> Linux 1394 - http://www.linux1394.org/
> SwissDisk  - http://www.swissdisk.com/
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
> Register for a JBoss Training Course.  Free Certification Exam
> for All Training Attendees Through End of 2005. For more info visit:
> http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
> _______________________________________________
> mailing list linux1394-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/linux1394-devel

-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/