Re: [2.6 patch] drivers/ieee1394/raw1394.c: fix a NULL pointer dereference

[Jody McIntyre]

On Mon, Nov 21, 2005 at 12:52:42AM +0100, Adrian Bunk wrote:

> The coverity checker spotted that this was a NULL pointer dereference in 
> the "if (copy_from_user(...))" case since the next step is to 
> kfree(cache->filled_head).
> 
> There's no need to free cache at this point, and it's getting free'd 
> later.

Applied.

Cheers,
Jody

> 
> 
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> 
> --- linux-2.6.15-rc1-mm2-full/drivers/ieee1394/raw1394.c.old	2005-11-20 22:08:57.000000000 +0100
> +++ linux-2.6.15-rc1-mm2-full/drivers/ieee1394/raw1394.c	2005-11-21 00:49:38.000000000 +0100
> @@ -2131,7 +2131,6 @@
>  			   req->req.length)) {
>  		csr1212_release_keyval(fi->csr1212_dirs[dr]);
>  		fi->csr1212_dirs[dr] = NULL;
> -		CSR1212_FREE(cache);
>  		ret = -EFAULT;
>  	} else {
>  		cache->len = req->req.length;
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
> Register for a JBoss Training Course.  Free Certification Exam
> for All Training Attendees Through End of 2005. For more info visit:
> http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
> _______________________________________________
> mailing list linux1394-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/linux1394-devel

-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/