Re: Linux 2.6.15-rc2

[Andi Kleen]

On Tue, Nov 22, 2005 at 05:05:07PM -0800, Andrew Morton wrote:
> Linus Torvalds <torvalds@xxxxxxxx> wrote:
> >
> > 
> > 
> > On Tue, 22 Nov 2005, Andrew Morton wrote:
> > 
> > > Jeffrey Hundstad <jeffrey.hundstad@xxxxxxxx> wrote:
> > > >
> > > >                 from fs/compat_ioctl.c:52,
> > > >                  from arch/x86_64/ia32/ia32_ioctl.c:14:
> > > > include/linux/ext3_fs.h: In function 'ext3_raw_inode':
> > > > include/linux/ext3_fs.h:696: error: dereferencing pointer to incomplete type
> > > 
> > > This might help?
> 
> The patch didn't help.
> 
> > 
> > Why does it happen at all, though?
> 
> davem recently merged a patch which adds ext3 ioctls to fs/compat_ioctl.c. 
> That required inclusion of ext3 and jbd header files.  Those files explode
> unpleasantly when CONFIG_JBD=n.

Or use ->compat_ioctl and do it in fs/ext3

> 
> No trivial fix was apparent - perhaps we should disable the compat wrappers
> if CONFIG_EXT3=n and/or CONFIG_JBD=n.

That's already done for a lot of other wrappers, so would be fine too

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/