Re: [2.6 patch] do not select NET_CLS
From: Thomas Graf
Date: Wed Nov 23 2005 - 05:26:47 EST
* David S. Miller <davem@xxxxxxxxxxxxx> 2005-11-22 14:37
> From: Patrick McHardy <kaber@xxxxxxxxx>
> Date: Mon, 21 Nov 2005 17:16:18 +0100
> > Adrian Bunk wrote:
> > > This patch therefore changes NET_CLS back to the 2.6.14 status quo of
> > > being an user-visible option.
> > I disagree with this patch. NET_CLS enables the infrastructure support
> > for classifiers. Users generally don't care about infrastructure but
> > directly usable things, so I'd prefer to have it automatically selected.
> > And there are lots of other cases where enabling a module causes changes
> > in the kernel image. Some examples include some of the netfilter stuff,
> > the IPsec transforms, NET_CLS_ROUTE4, the ieee80211 stuff, and a lot
> > more.
> I agree with Patrick.
In fact Patrick's explanation was exactly the motivation for me to
change it in the first place a few weeks back.
I thought about making cls_api aware to be built as module but then
the same would apply for ematches and the generic scheduling code
and it gets real complicated. It is possible with some heavy code
shuffling but not worth it I think.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/