Re: [PATCH] split sharpsl_pm.c into generic and corgi/spitzspecific parts

From: Richard Purdie
Date: Wed Nov 23 2005 - 15:16:00 EST


On Wed, 2005-11-23 at 20:49 +0100, Pavel Machek wrote:
> > 1. We probably shouldn't (can't?) make changes like this in -rc
> > kernels
>
> No, it does not really belong in -rc. I was hoping you would merge it
> in your tree so I do not have big patch here and could keep only
> collie changes...

Right, I misunderstood that. I'll happily maintain an in progress
version of that split-up patch in the Zaurus tree.

> > I have a proposal for how we proceed with this:
> >
> > After 2.6.15 is released, I envisage a patch which splits the common
> > sections of sharpsl_pm.c into arm/common and arm/mach-pxa/sharpsl.h into
> > include/arm/hardware/sharpsl_pm.h. I'm happy to generate that patch if
> > necessary and pass it to Russell. I'll try and create a patch to show
> > the structure I'm aiming for in the next couple of days but at the
> > moment we don't know exactly which code is common and I'd prefer to try
> > and do the split in one go.
>
> Ok, works for me. So I'll now concentrate on getting collie working
> and leave infrastructure to you...

Sounds good to me.

Richard




-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/