Re: [PATCH] Decrease number of pointer derefs in nf_conntrack_core.c

[Tim Schmielau]

On Fri, 9 Dec 2005, Jesper Juhl wrote:

> On 12/9/05, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > * Jesper Juhl <jesper.juhl@xxxxxxxxx> wrote:
> >
> > > orig:
> > >    text    data     bss     dec     hex filename
> > >   12636      49     760   13445    3485 net/netfilter/nf_conntrack_core.o
> > >
> > > patched:
> > >    text    data     bss     dec     hex filename
> > >   11825     183     632   12640    3160 net/netfilter/nf_conntrack_core.o
> >
> > just a question - are you sure the measurements are accurate in this
> > case? The patch looks too small to shave more than 800 bytes off .text!
> > If it's real then something really wrong is going on in gcc-land ...
> >
> I did all this with an allyesconfig kernel source and then did :
>    make net/netfilter/nf_conntrack_core.o
>    size net/netfilter/nf_conntrack_core.o
>    rm net/netfilter/nf_conntrack_core.o
> then applied the patch and redid
>    make net/netfilter/nf_conntrack_core.o
>    size net/netfilter/nf_conntrack_core.o
> 
> So I believe the numbers should be correct, but I'm not at home atm,
> so I can't verify right now. I won't have a chance to look at it until
> tomorrow, but then I'll double-check.


I get
orig:
   text    data     bss     dec     hex filename
  11745      67     728   12540    30fc net/netfilter/nf_conntrack_core.o

patched:
   text    data     bss     dec     hex filename
  11681      67     728   12476    30bc net/netfilter/nf_conntrack_core.o

> gcc --version
gcc (GCC) 4.0.2 20050901 (prerelease) (SUSE Linux)

Tim
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/