Re: [PATCH 3/3] [kconfig] Direct use of lxdialog routines by menuconfig

[Kurt Wall]

On Monday 12 December 2005 06:20 am, Petr Baudis wrote:
> Dear diary, on Mon, Dec 12, 2005 at 04:18:26AM CET, I got a letter
> where Kurt Wall <kwallinator@xxxxxxxxx> said that...
>

[...]

> > > +     submenu->data = (void *) !submenu->data;
> >
> > Shouldn't this be:
> >      submenu->data = (void *) (long) !submenu->data;
>
> You are right, it should be so at least for consistency - it'll be fixed
> in the next resend of the patch. I can't see why is it needed, though -
> shouldn't the int be padded to void* anyway?

The cast to long quiets a warning from gcc. Without the cast, it
complains:

$ make menuconfig
  HOSTCC  scripts/kconfig/mconf.o
scripts/kconfig/mconf.c: In function `conf':
scripts/kconfig/mconf.c:699: warning: cast to pointer from integer of 
different size
  HOSTLD  scripts/kconfig/mconf
scripts/kconfig/mconf arch/x86_64/Kconfig

I like the changes, though -- menuconfig is much snappier and easier on
the eyes without the nasty flashing.

Kurt
-- 
"I'd love to go out with you, but it's my parakeet's bowling night."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/