Re: [PATCH 3/3] [kconfig] Direct use of lxdialog routines by menuconfig

[Roman Zippel]

Hi,

On Mon, 12 Dec 2005, Petr Baudis wrote:

> In practice, this means that drawing on the screen is done with _MUCH_
> less overhead now, the screen updates are better optimalized as ncurses
> won't get reset everytime you display something, that also implies that
> the ugly screen flickering is done. As a cute side-effect, the dialogs
> are now rendered on the top of the menu or help panel.  In the future,
> this also gives us much more freedom for enhancing the user interface.

At least in the first version I'd prefer not to do draw the dialogs over 
each other. It's just weird if a string dialog pops up over the help text.
In the next version we should add some infrastructure to properly layer 
windows on top of other (and should also help with resizing).

> Compared to the previous version (from February 2003), this one should be
> less buggy (especially wrt. the escape character handling), should not
> crash while resizing and the resizing should have immediate effect
> (although things can still start looking ugly when you are resizing while
> not in a menu - to fix that properly, more liblxdialog integration is
> required). Also, the code is considerably simplified on few places.

The <esc><esc> as described in mconf.c still produces two exits, which is 
a little annoying if one is used to it. I don't know how easy it is to 
supress that second <esc>.

Otherwise it looks good. Regarding merging please coordinate with Sam and 
if you move it, I'd prefer to keep it in a subdirectory, e.g. just "mv 
scripts/lxdialog scripts/kconfig/lxdialog".

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/