Re: [PATCH] pid: Don't hash pid 0.

[Yuki Cuss]

Jan Engelhardt wrote:

> > @@ -148,6 +148,9 @@ int fastcall attach_pid(task_t *task, en
> > {
> > 	struct pid *pid, *task_pid;
> >
> > +	if (!nr)
> > +		goto out;
> > +
> >    
>
> How about nr==0, it would make it more obvious.
>
>
>
> Jan Engelhardt
>  

I am inclined to agree. `!nr' seems to imply some sort of an error 
condition; perhaps a comment could be placed in order to make why the 
case of (nr == 0) is being ignored.

- Yuki.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/