Re: [PATCH] pid: Don't hash pid 0.

[Jan Engelhardt]

>> How about nr==0, it would make it more obvious.
>
> I am inclined to agree. `!nr' seems to imply some sort of an error condition;

! seems to imply a boolean usually. (If this was Java, this would even 
be enforced.)
However, !x (and x) is scattered all around the kernel where 
x==0,x!=0 (or x==NULL,x!=NULL) would be more readable.

> perhaps a comment could be placed in order to make why the case of (nr == 0) is
> being ignored.
>
> - Yuki.
>

Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/