Re: [PATCH 1/3] s390: dasd extended error reporting module.

From: Jan Blunck
Date: Mon Feb 06 2006 - 06:28:47 EST


On Wed, Feb 01, Heiko Carstens wrote:

> From: Stefan Weinhuber <wein@xxxxxxxxxx>
>
> The DASD extended error reporting is a facility that allows to
> get detailed information about certain problems in the DASD I/O.
> This information can be used to implement fail-over applications
> that can recover these problems.
> This is a resubmit of this patch because at first submission it
> didn't get included due to Christoph's ioctl changes.
> Since these aren't in the -mm tree anymore this one should be
> merged now.

Why don't you use the sysfs for this purpose? This new character device
interface seems very odd to me. Why don't you introduce new attributes to the
dasd device for that purpose and make online pollable for failovers?

Or use dm-netlink to report the extended errors via multipath to the user
space.

Regards,
Jan

--
Jan Blunck jblunck@xxxxxxx
SuSE LINUX AG - A Novell company
Maxfeldstr. 5 +49-911-74053-608
D-90409 Nürnberg http://www.suse.de
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/