Re: [PATCH 0/12] LED Class, Triggers and Drivers

[Jiri Slaby]

Richard Purdie wrote:
>This is an updated version of the LED class/subsystem. The main change
>is the renamed API - I've settled on led_device -> led_classdev. Other
>minor issues like the error cases in the timer trigger were also fixed.
Seems good, but some issues:
Use more macros
	struct led_classdev *led_cdev = dev->class_data;
	pdev->resource[i].start, pdev->resource...
__init and __exit
	static int __devinit ixp4xxgpioled_init(void)
	static void ixp4xxgpioled_exit(void)
	static void nand_base_exit(void)
	tosaled_{init,exit}, corgiled_{init,exit}, spitzled_{init,exit}
coding style
	static void __exit timer_trig_exit (void)
	static inline void led_set_brightness(struct led_classdev *led_cdev, enum led_brightness value) -- more than 80 columns
+			led_cdev->trigger->deactivate(led_cdev);
+
+	}
	ixp4xxgpioled_brightness_set -- a little bit ugly
+static int apply_to_all_leds(struct platform_device *pdev,
+	void (*operation)(struct led_classdev *pled)) {
{ on the next line

regards,
--
Jiri Slaby         www.fi.muni.cz/~xslaby
~\-/~      jirislaby@xxxxxxxxx      ~\-/~
B67499670407CE62ACC8 22A032CC55C339D47A7E
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/