Re: [PATCH] hpet header sanitization

[Randy.Dunlap]

On Wed, 22 Mar 2006 21:08:02 +0100 Arjan van de Ven wrote:

> On Wed, 2006-03-22 at 09:26 -0800, Randy.Dunlap wrote:
> > On Wed, 22 Mar 2006 10:02:19 +0100 Arjan van de Ven wrote:
> > 
> > > On Tue, 2006-03-21 at 16:26 -0800, Randy.Dunlap wrote:
> > > > On Tue, 21 Mar 2006 16:13:03 -0800 Andrew Morton wrote:
> > > > 
> > > > > "Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> wrote:
> > > > > >
> > > > > > From: Randy Dunlap <rdunlap@xxxxxxxxxxxx>
> > > > > > 
> > > > > > Add __KERNEL__ block.
> > > > > > Use __KERNEL__ to allow ioctl interface to be usable.
> > > > > 
> > > > > hm, why?
> > > > 
> > > > because there is a test/example source file in (inside)
> > > > Documentation/hpet.txt that won't build otherwise.
> > > > And because hpet.h contains _userspace_ ioctl interface struct
> > > > and macros...
> > > 
> > > 
> > > then please split the header in 2 parts; one for the kernel
> > > and one for userspace
> > 
> > so would you tell me what the purpose (use) of __KERNEL__
> > is meant to be, please?
> 
> for legacy headers.. the same ;)

"the same" as what?  I'm not understanding these partial sentences.

> Thats no reason to fix up new cases... things should get better not just
> get a small rubber bandaid...

Yes, I'm not disagreeing with the no-bandaids part.  I just haven't
read that __KERNEL__ is legacy only.


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/