Re: [PATCH] swsusp: separate swap-writing/reading code

[Rafael J. Wysocki]

Hi,

On Thursday 23 March 2006 22:13, Nigel Cunningham wrote:
> On Friday 24 March 2006 03:02, Linux Kernel Mailing List wrote:
> > commit 61159a314bca6408320c3173c1282c64f5cdaa76
> > tree 8e1b7627443da0fd52b2fac66366dde9f7871f1e
> > parent f577eb30afdc68233f25d4d82b04102129262365
> > author Rafael J. Wysocki <rjw@xxxxxxx> Thu, 23 Mar 2006 19:00:00 -0800
> > committer Linus Torvalds <torvalds@xxxxxxxxxxx> Thu, 23 Mar 2006 23:38:07
> > -0800
> >
> > [PATCH] swsusp: separate swap-writing/reading code
> >
> > Move the swap-writing/reading code of swsusp to a separate file.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> > Acked-by: Pavel Machek <pavel@xxxxxx>
> > Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
> > Signed-off-by: Linus Torvalds <torvalds@xxxxxxxx>
> 
> I guess I missed this one somehow. Using a bitmap for allocated swap is really 
> inefficient because the values are usually not fragmented much. Extents would 
> have been a far better choice.

I agree it probably may be improved.  Still it seems to be good enough.  Further,
it's more efficient than the previous solution, so I consider it as an improvement.
Also this code has been tested for quite some time in -mm and appears to
behave properly, at least we haven't got any bug reports related to it so far.

Currently I'm not working on any better solution.  If you can provide any
patches to implement one, please submit them, but I think they'll have to be
tested for as long as this code, in -mm.

Greetings,
Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/