Re: Two comments on the H.323 conntrack/NAT helper

[Jing Min Zhao]

----- Original Message ----- 
From: "Adrian Bunk" <bunk@xxxxxxxxx>
To: "Jing Min Zhao" <zhaojignmin@xxxxxxxxxxx>
Cc: <netdev@xxxxxxxxxxxxxxx>; <netfilter-devel@xxxxxxxxxxxxxxxxxxx>; 
<linux-kernel@xxxxxxxxxxxxxxx>
Sent: Thursday, March 23, 2006 7:13 PM
Subject: Two comments on the H.323 conntrack/NAT helper


> Two comments on the H.323 conntrack/NAT helper:
Thank you for your advice.

> - the function prototypes in ip_nat_helper_h323.c are _ugly_,
>  please move them to a header file
Correct, I'll do that.

> - is there a reason for not using EXPORT_SYMBOL_GPL?
No, I just forgot it. I'll change this too.

> cu
Hope I can get more advice from you.

> Adrian
>
> --
>
>       "Is there not promise of rain?" Ling Tan asked suddenly out
>        of the darkness. There had been need of rain for many days.
>       "Only a promise," Lao Er said.
>                                       Pearl S. Buck - Dragon Seed
That's Hepburn :-)

>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/