Re: Parenthesize macros in xfs

[Andreas Schwab]

Jan Engelhardt <jengelh@xxxxxxxxxxxxxxx> writes:

>>> -#define swap(a, b)					\
>>> +#define swap(a, b) do {					\
>>>  	if (swaptype == 0) {				\
>>>  		long t = *(long *)(a);			\
>>>  		*(long *)(a) = *(long *)(b);		\
>>>  		*(long *)(b) = t;			\
>>>  	} else						\
>>> -		swapfunc(a, b, es, swaptype)
>>> +		swapfunc(a, b, es, swaptype)		\
>>> +} while(0)
>>                                           ^^
>>Missing semicolon.
>>
>
> It was missing before too. ;)

No, previously it was provided at the call site.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@xxxxxxx
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/